Add npipe as a valid mount type #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aroskuski, Could you please make the change focused on adding NPIPE mount type (easy to accept), and extract the Windows testing into a separate PR (needs a discussion)? Thank you! |
|
@aroskuski thank you! I think the change is valid, I was just working on preparing a release and wanted to include your change, but wasn't ready to review that test-related change 👍 Will have a look after the release 👍 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.40 of the API (or at least I think it was that version, had to manually search through versions of the doc) added npipe as a valid mount type. This is necessary for certain cases, like mounting the default docker pipe on Windows inside a container.
I've manually tested that this change works, but automated testing has proven a bit of a challenge. It's kind of too trivial to write a meaningful unit test for (though I did go through and made sure the all the existing tests passed, on Windows, even), and there doesn't appear to be an obvious way to add an integration test for a Windows-only feature.