-
-
Notifications
You must be signed in to change notification settings - Fork 2k
ARM build fix #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM build fix #1971
Conversation
|
The error shown by |
|
Why did the latest pipeline on |
|
See my #1965 (comment) |
|
Wait. I may miss something here, but couldn't we:
Did I miss something? I know we're not testing against |
|
Yes, also possible. But I'll start now on adding buildx. Let's see how this goes π |
|
Another CI adjustment is needed. I am just testing it. If it's fine, i'll provide a hopefully final PR. |
|
The CI will be fine with #1974 π |
|
oh i approved the changes but the workflow wasn't finished. Auto-merge went through tho so we need to keep an eye on the running CI EDIT: the build went through, now tests are running |
|
Tests are also fine π |
When I contributed to Gatsby they had a auto-merge on green (all tests pass), not sure if that's supported by default on Github for maintainers or was via some third-party integration they added. Additionally with Github Actions, that may not always be reliable as some CI jobs can be related but triggered after the initial checks/actions complete. I've seen the UI only show 1 listing in the check suite as a result and treat it as "green" but then the 2nd workflow which manually manages it's status causing the UI to update with a 2nd check item. Having some delay timer might work around that concern. |
|
The problem is that we can define which workflows need to pass at least before a merge is possible. We have chosen the "linting" one here as this one runs every time. We could also add the "test_pr" but then this one also needs to run even if we only add a typo fix on readme for example. |
Description
Possible arm build fix
Fixes #1965
Type of change
Checklist:
docs/)