Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@casperklein
Copy link
Member

Description

Possible arm build fix

Fixes #1965

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein mentioned this pull request May 15, 2021
8 tasks
@georglauterbach
Copy link
Member

The error shown by docker buildx is very cryptic indeed... I'd just restart the test.

@georglauterbach
Copy link
Member

georglauterbach commented May 15, 2021

Why did the latest pipeline on master succeed? 🀣

@casperklein
Copy link
Member Author

See my #1965 (comment)

@georglauterbach
Copy link
Member

georglauterbach commented May 15, 2021

Wait. I may miss something here, but couldn't we:

  1. Turn on the --insecure setting for curl, as this could/should be the reason for CI to fail
  2. Revert Add ARM platformsΒ #1970 to just test against amd64 (and start praying)
  3. With a bit of luck, habe CI fixed and a lot less work :D

Did I miss something? I know we're not testing against armXX, but this way no one has a lot of work ATM.

@casperklein
Copy link
Member Author

Yes, also possible. But I'll start now on adding buildx. Let's see how this goes πŸ˜„

@casperklein casperklein enabled auto-merge (squash) May 16, 2021 17:08
@casperklein casperklein disabled auto-merge May 16, 2021 17:12
@casperklein
Copy link
Member Author

Another CI adjustment is needed. I am just testing it. If it's fine, i'll provide a hopefully final PR.

@casperklein
Copy link
Member Author

The CI will be fine with #1974 πŸ‘

@casperklein casperklein changed the title Possible arm build fix ARM build fix May 16, 2021
@casperklein casperklein enabled auto-merge (squash) May 16, 2021 18:55
@casperklein casperklein self-assigned this May 16, 2021
@casperklein casperklein disabled auto-merge May 16, 2021 18:56
@casperklein casperklein enabled auto-merge (squash) May 16, 2021 18:56
@casperklein casperklein merged commit 0ba8630 into master May 16, 2021
@casperklein casperklein deleted the arm-build-fix branch May 16, 2021 19:05
@wernerfred
Copy link
Member

wernerfred commented May 16, 2021

oh i approved the changes but the workflow wasn't finished. Auto-merge went through tho so we need to keep an eye on the running CI

EDIT: the build went through, now tests are running

@casperklein
Copy link
Member Author

Tests are also fine πŸŽ‰

@polarathene
Copy link
Member

oh i approved the changes but the workflow wasn't finished. Auto-merge went through tho so we need to keep an eye on the running CI

When I contributed to Gatsby they had a auto-merge on green (all tests pass), not sure if that's supported by default on Github for maintainers or was via some third-party integration they added.

Additionally with Github Actions, that may not always be reliable as some CI jobs can be related but triggered after the initial checks/actions complete. I've seen the UI only show 1 listing in the check suite as a result and treat it as "green" but then the 2nd workflow which manually manages it's status causing the UI to update with a 2nd check item. Having some delay timer might work around that concern.

@wernerfred
Copy link
Member

The problem is that we can define which workflows need to pass at least before a merge is possible. We have chosen the "linting" one here as this one runs every time. We could also add the "test_pr" but then this one also needs to run even if we only add a typo fix on readme for example.
I will double check if there are new settings available, otherwise we be especially cautious about the "enable auto-merge" feature if there is a test running currently (or to approve only if the test passes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants