tests(refactor): Dovecot quotas #3068
Conversation
Test cases are just cut + paste, no logic changed there yet.
Plus some additional bug fixes in the disabled test case
Removes the extra variables and filtering in favour of explicit values instead of matching for comparison. - Easier at a glance to know what is actually expected. - Additionally reworks the quota limit checks in other test cases. Using a different formatter for `doveadm` is easier to match the desired value (`Limit`).
|
@polarathene I can take the |
I think we're mostly done. I've been a bit busy lately, but should be able to get back to resuming this PR and finishing off the After that (but you're more than welcome to get started on all the parallel folder tests), it'd be good to see how many of the It'd also be helpful for once adding in proper DNS I guess, so an FQDN can be used with a mail command or similar instead of |
|
KK! I will adjust |
|
This is now the last blocking PR for #3146. |
This PR doesn't need to block v12 release. The full test suite refactoring didn't quite make it for v12 unfortunately. I'll resume this PR later this month. Priority has been other issues and review for DMS v12 and commitments outside of DMS. There's still a blocker apparently which should be resolved if |
|
May I assist you in an way to get this PR merged?:) |
I think I have changes on the local branch since I halted progress on this. You could probably assist by slowing down so I have less distractions 😝 😂 I'll try to resume this before the end of the month. If you'd like to write a test for the getmail PR so that can get merged, that could be helpful. It should mostly be similar to fetchmail tests which are only for configuration I think, no point adding friction with proper tests if the similar existing feature we maintain is lacking at that too. I believe it needs to also bring in getmail via |
polarathene
left a comment
There was a problem hiding this comment.
Since I never seem to have sufficient time for addressing my contributions in DMS and this one is not only low priority for me but tricky to get access to my local copy due to technical issues earlier in the year.. If tests pass we might as well merge this as-is 🤷♂️
|
I've addressed conflicts and tests pass. Should be ok to merge 👍 I'd still like to revisit this properly, but it's better to move things along as we're nearing a full year since I had to put this on hold. A separate TODO issue has been opened instead as a reminder. |
|
Documentation preview for this PR is ready! 🎉 Built with commit: 8a9e5c3 |
* chore: Extract out Dovecot Quota test cases into new test file Test cases are just cut + paste, no logic changed there yet. * chore: Rename test case descriptions * chore: Use `setup ...` methods instead of direct calls * chore: Adjust `_run_in_container_bash` to `_run_in_container` Plus some additional bug fixes in the disabled test case * tests(refactor): Revise ENV test cases for max mailbox and message sizes * tests(refactor): Revise ENV test cases for mailbox and message limits v2 Removes the extra variables and filtering in favour of explicit values instead of matching for comparison. - Easier at a glance to know what is actually expected. - Additionally reworks the quota limit checks in other test cases. Using a different formatter for `doveadm` is easier to match the desired value (`Limit`). * chore: Sync improvement from `tests.bats` master --- NOTE: This PR has been merged to avoid additional maintenance burden without losing the improvements. It was not considered complete, but remaining tasks were not documented in the PR.
Description
Extracting out the quota tests and revising them a little.
WIP - Almost done.(**EDIT: I was not able to complete the PR as intended, but it is likely fine to merge, tracking issue for potentially revisiting this work)Type of change
Checklist: