Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: sed logic for ENABLE_QUOTAS=0 is not actionable #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperklein merged 4 commits into from
Dec 20, 2023
Merged

fix: sed logic for ENABLE_QUOTAS=0 is not actionable #3715

casperklein merged 4 commits into from
Dec 20, 2023

Conversation

@casperklein
Copy link
Member

@casperklein casperklein commented Dec 19, 2023 •
edited
Loading

Description

Fixes #3706

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Dec 19, 2023
polarathene
polarathene previously approved these changes Dec 19, 2023
View reviewed changes
@casperklein casperklein marked this pull request as ready for review December 19, 2023 13:03
@casperklein casperklein added this to the v13.1.0 milestone Dec 19, 2023
@casperklein casperklein added area/scripts kind/bug/fix A fix (PR) for a confirmed bug labels Dec 19, 2023
@casperklein casperklein enabled auto-merge (squash) December 19, 2023 13:04
@casperklein casperklein changed the title Remove sed statement Fix sed error, when ENABLE_QUOTAS=0 is set Dec 19, 2023
polarathene
polarathene requested changes Dec 19, 2023
View reviewed changes
@casperklein @polarathene
Update CHANGELOG.md
9e2c6eb 
Co-authored-by: Brennan Kinney <[email protected]>
@casperklein casperklein merged commit 3adb53e into docker-mailserver:master Dec 20, 2023
@polarathene polarathene changed the title Fix sed error, when ENABLE_QUOTAS=0 is set fix: sed logic for ENABLE_QUOTAS=0 is not actionable Dec 20, 2023
reneploetz pushed a commit to reneploetz/docker-mailserver that referenced this pull request Dec 20, 2023
@casperklein @reneploetz
Remove sed statement (docker-mailserver#3715)
72e91b4
@casperklein casperklein deleted the sed branch January 30, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Milestone

v13.1.0

Development

Successfully merging this pull request may close these issues.

bug report: ENABLE_QUOTA=0 produces sed error.

2 participants

@casperklein @polarathene