Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: supervisor-app.conf - Correct the log location for postgrey #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polarathene merged 4 commits into from
Dec 29, 2023
Merged

fix: supervisor-app.conf - Correct the log location for postgrey #3724

polarathene merged 4 commits into from
Dec 29, 2023

Conversation

@polarathene
Copy link
Member

@polarathene polarathene commented Dec 25, 2023 •
edited
Loading

Description

Looks like this should have been like every other service and reference a log file(s) based on program name in the supervisor log directory.

This should fix a recently reported failure from running the new make run-local-instance dev command:

Error: The directory named as part of the path /var/log/mail/mail.log does not exist in section 'program:postgrey' (file: '/etc/supervisor/conf.d/supervisor-app.conf')
For help, use /usr/bin/supervisord -h
make: *** [Makefile:37: run-local-instance] Error 2

NOTE: I haven't verified this yet, just preparing the PR in anticipation that it addresses the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@polarathene
fix: supervisor-app.conf - Correct postgrey log location
b3b1403 
Looks like this should have been like every other service and reference a log file(s) based on program name in the supervisor log directory.
@polarathene polarathene added this to the v13.1.0 milestone Dec 25, 2023
@polarathene polarathene self-assigned this Dec 25, 2023
@polarathene polarathene mentioned this pull request Dec 25, 2023
Merged
10 tasks
@polarathene

This comment was marked as resolved.

Sign in to view
@keval6b
Copy link
Contributor

keval6b commented Dec 26, 2023 •
edited
Loading

Just testing this branch, getting the same error but with rspamd now:

Error: The directory named as part of the path /var/log/mail/rspamd.log does not exist in section 'program:rspamd' (file: '/etc/supervisor/conf.d/supervisor-app.conf')

Perhaps there's something else at play here?

@keval6b
Copy link
Contributor

keval6b commented Dec 26, 2023 •
edited
Loading

Ok nevermind... It appears some remaining docker-data or something was messing things up. I cleaned the lot during some bisecting and now it appears to be working. I'm just so confused as to why it's now working as I even re-cloned the repo...

@polarathene
Copy link
Member Author

polarathene commented Dec 26, 2023

Ok nevermind... It appears some remaining docker-data or something was messing things up.

That does seem odd, but glad it's not likely a bug in v13.1 😅

I guess we can merge this as an improvement still. Shall we delay it to v14 then @georglauterbach ? (otherwise feel free to merge)

If you'd like to share some information about your environment here, it might help troubleshoot if we get any similar reports.

I know I've recently had some issues with WSL2 with Docker (not possible to use host networking mode, at least not with binding ports within WSL distro, whilst bridge networks aren't accessible on the Windows host, only localhost via port publishing...which would require split DNS for my CoreDNS server to return 127.0.0.1 to windows and container IPs within containers).

@georglauterbach
Copy link
Member

georglauterbach commented Dec 26, 2023

I think it's best to delay until v14.0.0.

@polarathene polarathene modified the milestones: v13.1.0, v14.0.0 Dec 27, 2023
@polarathene polarathene merged commit 0889b0f into master Dec 29, 2023
@polarathene polarathene deleted the fix/supervisor-postgrey-log-location branch December 29, 2023 20:59
@polarathene polarathene mentioned this pull request Dec 31, 2023
Merged
9 tasks
@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.2.0 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@polarathene polarathene

Labels

area/configuration (file) area/scripts kind/bug/fix A fix (PR) for a confirmed bug service/security/postgrey

Projects

None yet

Milestone

v13.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@polarathene @keval6b @georglauterbach @casperklein