Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests: Replace wc -l with grep -c #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperklein merged 4 commits into from
Jan 6, 2024
Merged

tests: Replace wc -l with grep -c #3752

casperklein merged 4 commits into from
Jan 6, 2024

Conversation

@casperklein
Copy link
Member

@casperklein casperklein commented Jan 5, 2024 •
edited
Loading

Description

grep
-c, --count
Suppress normal output; instead print a count of matching lines for each input file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein changed the title tests: remove 'wc -l' tests: Replace wc -l with grep -c Jan 5, 2024
@casperklein casperklein marked this pull request as ready for review January 5, 2024 22:56
@casperklein casperklein self-assigned this Jan 5, 2024
@casperklein casperklein added area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Jan 5, 2024
@casperklein casperklein added this to the v14.0.0 milestone Jan 5, 2024
polarathene
polarathene approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use --count? 😅

Either is fine, just makes it a little more obvious (I'm terrible at remembering short flags I don't use often).

@casperklein
Copy link
Member Author

casperklein commented Jan 6, 2024

I used the short form, to match the existing style of the other (short) arguments.

@casperklein casperklein merged commit 0eb4ac7 into docker-mailserver:master Jan 6, 2024
@casperklein casperklein deleted the remove-wc-l branch January 6, 2024 16:07
@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.3.0 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/tests kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v13.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @polarathene @georglauterbach