Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@polarathene
Copy link
Member

@polarathene polarathene commented Jan 15, 2024

Description

General improvements as noted below, makes the test more robust for any future additions.

Revisions:

  • Removed some outdated comments about wrappers / timings that are no longer relevant.
  • pgrep check now uses --full which was initially required for MTA-STS support to pass the test, whilst now it is more useful for matching postfix/amavis better.
  • pkill now kills the process and asserts against the oldest matched process PID from pgrep. This should be the process that spawned any relevant children. Matching against the PID is better for targeting what we're interested in, since the process path is not always consistent (/usr/sbin/amavi vs /usr/sbin/amavisd-new).
  • Added context for the python3 and postgrey services, along with additional maintainance comments on pkill / pgrep usage.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@polarathene polarathene added this to the v14.0.0 milestone Jan 15, 2024
@polarathene polarathene self-assigned this Jan 15, 2024
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two smaller nitpicks; other than that LGTM 👍🏼

Co-authored-by: Georg Lauterbach <[email protected]>
@polarathene polarathene modified the milestones: v14.0.0, v13.3.0 Jan 15, 2024
@polarathene

This comment was marked as resolved.

@polarathene polarathene enabled auto-merge (squash) January 17, 2024 09:45
@polarathene polarathene merged commit 437114c into master Jan 17, 2024
@polarathene polarathene deleted the tests/revise-process-check-restart branch January 17, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants