tests: Revise process_check_restart.bats
#3780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General improvements as noted below, makes the test more robust for any future additions.
Revisions:
pgrepcheck now uses--fullwhich was initially required for MTA-STS support to pass the test, whilst now it is more useful for matching postfix/amavis better.pkillnow kills the process and asserts against the oldest matched process PID frompgrep. This should be the process that spawned any relevant children. Matching against the PID is better for targeting what we're interested in, since the process path is not always consistent (/usr/sbin/amavivs/usr/sbin/amavisd-new).pkill/pgrepusage.Type of change
Checklist:
CHANGELOG.md