Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: CHANGELOG.md - Add rsyslog breaking changes for v14 #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperklein merged 4 commits into from
Jan 30, 2024
Merged

chore: CHANGELOG.md - Add rsyslog breaking changes for v14 #3854

casperklein merged 4 commits into from
Jan 30, 2024

Conversation

@casperklein
Copy link
Member

@casperklein casperklein commented Jan 29, 2024

Description

Fixes #3403 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Jan 29, 2024
@casperklein casperklein added this to the v14.0.0 milestone Jan 29, 2024
@casperklein casperklein marked this pull request as ready for review January 29, 2024 22:40
polarathene

This comment was marked as outdated.

Sign in to view

polarathene
polarathene requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a little bit more verbose than intended 😓

I'll apply the two suggested changes, rest of the feedback is just heavy documentation for my benefit.

EDIT: Oh just realized the original notes were mostly paraphrased from the Debian changelog 😄

@polarathene polarathene mentioned this pull request Jan 30, 2024
Open
polarathene
polarathene previously approved these changes Jan 30, 2024
View reviewed changes
@polarathene polarathene changed the title CHANGELOG.md: add breaking changes from rsyslog chore: CHANGELOG.md - Add rsyslog breaking changes for v14 Jan 30, 2024
@polarathene polarathene added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Jan 30, 2024
@casperklein casperklein enabled auto-merge (squash) January 30, 2024 21:43
@casperklein casperklein merged commit d65b2f3 into docker-mailserver:master Jan 30, 2024
@casperklein casperklein deleted the changelog branch January 30, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach left review comments

Assignees

@casperklein casperklein

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @polarathene @georglauterbach