Rspamd: improve DKIM key generation #3876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rm` would fail when one of the files is not present, which is quite undesirable log (not harmful until `set -e` is introduced).
5c678a6 to
3b1d504
Compare
1 task
polarathene
approved these changes
Feb 5, 2024
Member
polarathene
left a comment
There was a problem hiding this comment.
Approving since __do_as_rspamd_user() only appears to be relevant to the rspamd DKIM generation script.
We'd have avoided all this if permissions on the config volume weren't relevant correct? After the LDAP feature rework is done I'll fix up DKIM keypair generation for v15 too.
Member
Author
Absolutely! |
casperklein
reviewed
Feb 6, 2024
Comment on lines
+180
to
+182
| [[ -f ${PUBLIC_KEY_FILE} ]] && rm "${PUBLIC_KEY_FILE}" | ||
| [[ -f ${PUBLIC_KEY_DNS_FILE} ]] && rm "${PUBLIC_KEY_DNS_FILE}" | ||
| [[ -f ${PRIVATE_KEY_FILE} ]] && rm "${PRIVATE_KEY_FILE}" |
Member
There was a problem hiding this comment.
Maybe for a follow up "tuning":
rm -f "${PUBLIC_KEY_FILE}" etc. will always succeed, no matter if the file exist or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3873
Type of change
Checklist
docs/)CHANGELOG.md