Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@polarathene
Copy link
Member

Description

Fixes #3896

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is more obvious that the command is continuing

I would suggest also adding an output of the public key at the end or a success log with the key path
what do you think?

@polarathene
Copy link
Member Author

I would suggest also adding an output of the public key at the end or a success log with the key path
what do you think?

The rspamd version supports this AFAIK.

Nobody is interested in contributing changes to these existing two scripts for DKIM AFAIK, it's better to replace them with the single keypair generation method I've proposed using smallstep step-cli. You'll find that supports the public key output too.

I'll tackle that for v15 release, I need to first wrap up a task unrelated to DMS before I can come return to DMS LDAP PR work (docs + refactor). The docs are blocking on v14 so hopefully I can sort that out by the weekend 😅

As for key path, not that important. New approach will have a predictable location and storage convention for the DMS config volume. Those will be copied to an internal location in DMS at runtime with config generation handled.

@polarathene polarathene merged commit 67faa95 into master Feb 20, 2024
@polarathene polarathene deleted the fix/tools-dkim-conflict-log branch February 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/features area/scripts kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug report: log: command not found

4 participants