@georglauterbach @polarathene Not related to this PR and just cosmetic: What is your opinion about renaming target/supervisor/conf.d/supervisor-app.conf to something like DMS.conf or similar?

@georglauterbach @polarathene Not related to this PR and just cosmetic: What is your opinion about renaming target/supervisor/conf.d/supervisor-app.conf to something like DMS.conf or similar?

Not an issue if you ask; we should classify it as breaking, though.

What is your opinion about renaming target/supervisor/conf.d/supervisor-app.conf to something like DMS.conf or similar?

I don't see any value in doing so (especially as uppercase). I'd rather a motivation for it, as we do have a separate config for sasl login mechanisms too, you could probably split it into separate service groups if that makes more sense? 🤷‍♂️

I think "supervisor-app" is completely generic. The "app" (all services combined) we are using is called docker-mailserver (DMS). So it makes more sense to me, to name the config accordingly.

Having service groups is something I'd support as well. Maybe for anti-spam, then dovecot-specific, and then dms.conf for the rest?

Having it all in one place, like now, is fine for me. The file isn't that big or confusing that would justify a splitting IMO.
It is really just the name supervisor-app, that triggers me for some time now 😆 If you both want to keep that name, that's fine 👍

Nah, go ahead and change it to dms.conf, I like that one better too.

The file isn't that big or confusing that would justify a splitting IMO.

I was thinking more in terms of feature isolation. I probably won't get around to it, but thought about exploring a file structure that groups scripts related to features/services together, just gets a bit messy when integration is involved. Probably not worth it.

It is really just the name supervisor-app, that triggers me for some time now 😆 If you both want to keep that name, that's fine 👍

I don't mind either way. dms-services.conf might be more appropriate than just dms.conf if you do go forward with such a change. Might be best to schedule it for v15, as v14 breaking changes is already quite a large list in changelog 😅

dms-services.conf sounds perfect 👍

Might be best to schedule it for v15, as v14 breaking changes is already quite a large list in changelog

One more tiny change makes no big difference IMO. But I don't care if this is done in v14 or 15.

I agree that this can easily go into v14.

Fair enough 👍