fix: Prevent stderr being written to /etc/postfix/main.cf
#4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stderr` is filtered by `grep` to discard unwanted (expected) log noise when appending the override `postfix-main.cf` content (_updated settings did not replace earlier defined instances_). That `grep` filter introduced a regression into DMS v14 release, since any other `stderr` content not being excluded was now blended into `stdout` and redirected with the original `stdout` output for the `postconf -n` command. The fix is to ensure the `grep` output is redirect to `stderr` to avoid that mishap.
1 task
georglauterbach
approved these changes
Aug 1, 2024
Member
georglauterbach
left a comment
There was a problem hiding this comment.
Wow, even for me this seems ridiculous 😆
casperklein
approved these changes
Aug 1, 2024
Member
|
Not easy to spot, but once you understood how it works, it's still logical 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regression fix. A good example of why I loathe such logic with shell scripts 😩
stderris filtered bygrepto discard unwanted (expected) log noise when appending the overridepostfix-main.cfcontent (updated settings did not replace earlier defined instances).That
grepfilter introduced a regression into DMS v14 release, since any otherstderrcontent not being excluded was now blended intostdoutand redirected with the originalstdoutoutput for thepostconf -ncommand.The fix is to ensure the
grepoutput is redirect tostderrto avoid that mishap.Fixes #4145
Type of change
Checklist
CHANGELOG.md