Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RoelSG
Copy link
Contributor

@RoelSG RoelSG commented Sep 18, 2024

Generate systemd is deprecated and Quadlets are now used. I have spent some time getting Quadlet to work, so I added some findings to the documentation. It is my first time contributing to documentation, so excuse my English if it comes across a bit rambly.

I have only added information, and have not removed any. However, generate-systemd is now deprecated and slirp4netns is out in favour of pasta. Pasta in particular is a lot easier to configure, but is still complicated to include into a docker-compose, which I do not use anymore.

Using podlet you can also translate a docker-compose to a Quadlet. Quadlets themselves behave a lot like individual compose files, but are managed by systemd.

  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Generate systemd is deprecated and Quadlets are now used. I have spent some time getting Quadlet to work, so I added some findings to the documentation. It is my first time contributing to documentation, so excuse my English if it comes across a bit rambly.

I have only added information, and have not removed any. However, generate-systemd is now deprecated and slirp4netns is out in favour of pasta. Pasta in particular is a lot easier to configure, but is still complicated to include into a docker-compose, which I do not use anymore.

Using podlet you can also translate a docker-compose to a Quadlet. Quadlets themselves behave a lot like individual  compose files, but are managed by systemd.
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My system crashed during this review, I am accessing via phone where thankfully github has persisted what I had.

It's incomplete but will have to do for now. I may be slow to respond due to this event. Please don't merge until I return as config section will need some revision too.

@georglauterbach georglauterbach added area/documentation kind/upstream Related to, or resolved by, an upstream project - Not resolvable within DMS labels Sep 25, 2024
@georglauterbach georglauterbach added this to the v15.0.0 milestone Sep 25, 2024
@georglauterbach
Copy link
Member

@RoelSG please also add a short entry in our CHANGELOG.md :)

@polarathene
Copy link
Member

I'll have time for returning to this within 48 hours. I need to spin up a VPS and verify some of the contribution to complete my review.

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to wrap up some notes on the config section, then I'll provide some revision for the related docs. Sharing what I have so far in the meantime.

RoelSG and others added 7 commits October 16, 2024 22:20
- Minor revisions to current PR content.
- Link refs shifted to bottom of document.
- "Rootfull" => "Rootful" correction.
- Better document differences between `pasta` and `slip4netns`.
- Initial revision on Quadlet example section:
  - `network-online.target` wants/after requirements are implicit. No need to add this.
  - `Network=pasta` not required from Podman 5.0.
  - `HostName` should match config elsewhere in docs as `mail.example.com`.
@polarathene
Copy link
Member

Apologies for the delay, I had a stressful end of October that led to a burn out. I've committed the bulk of what I had managed prior to the burn out.

I'll go over the current state as I recall I had a few more parts I wanted to address and polish up, then we can get this approved and merged 🚀

@polarathene polarathene changed the title Update podman.md docs: Podman - Document how to setup DMS with Quadlet Nov 10, 2024
@github-actions github-actions bot added the meta/stale This issue / PR has become stale and will be closed if there is no further activity label Dec 11, 2024
@casperklein casperklein removed the meta/stale This issue / PR has become stale and will be closed if there is no further activity label Dec 11, 2024
@docker-mailserver docker-mailserver deleted a comment from github-actions bot Dec 11, 2024
@docker-mailserver docker-mailserver deleted a comment from github-actions bot Dec 11, 2024
@polarathene polarathene added the stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI label Dec 11, 2024
@polarathene
Copy link
Member

Sorry about the lack of activity here, bit pre-occupied elsewhere but will return to this in the 2nd half of the month.

@RoelSG
Copy link
Contributor Author

RoelSG commented Dec 11, 2024

Not a problem, this is not a bugfix or something, I'll check in periodically.

@georglauterbach georglauterbach modified the milestones: v15.0.0, v15.1.0 Jan 19, 2025
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through stuff I've had open, came across these changes which AFAIK were going towards a final revision until I had to put that on hold. I'll apply what I have here as at a glance it does seem to be an improvement overall.

I am relocating presently but still plan to investigate the concern with network drivers I had so that this can finally get wrapped up (hopefully later this month 😓)

@georglauterbach
Copy link
Member

I resolved the merge conflicts for this PR, as I'd like to get it merged. @polarathene what's the status here - can we ship this update? I do not need everything to be polished right away - if the gist is good, we can build on that.

@polarathene
Copy link
Member

I am presently unable to context shift back to this PR, there may be some concerns with the current state of it where I wanted to revise the content or verify.

I recall some claims regarding the networking drivers that might be inaccurate in the scope of the two discussed or rootless vs rootful contexts. So while I'm a little iffy about merging an incomplete update, I still think this information is valuable to our users and we'll need to defer to future contributions to correct any oversights as I'm unsure when I'll have time to prioritize this on the backlog.

I will merge the PR in it's current state and add a reference to my TODO issue.

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I've refined it as best I could with the time I had to spare.

The information should be quite helpful to Podman users and for maintainers to grok when necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Documentation preview for this PR is ready! 🎉

Built with commit: ee8d4b0

@polarathene polarathene dismissed casperklein’s stale review August 1, 2025 00:22

Review feedback was applied long ago.

@polarathene polarathene merged commit b6e5d34 into docker-mailserver:master Aug 1, 2025
3 checks passed
@polarathene polarathene mentioned this pull request Aug 1, 2025
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/upstream Related to, or resolved by, an upstream project - Not resolvable within DMS stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants