-
-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: Podman - Document how to setup DMS with Quadlet #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generate systemd is deprecated and Quadlets are now used. I have spent some time getting Quadlet to work, so I added some findings to the documentation. It is my first time contributing to documentation, so excuse my English if it comes across a bit rambly. I have only added information, and have not removed any. However, generate-systemd is now deprecated and slirp4netns is out in favour of pasta. Pasta in particular is a lot easier to configure, but is still complicated to include into a docker-compose, which I do not use anymore. Using podlet you can also translate a docker-compose to a Quadlet. Quadlets themselves behave a lot like individual compose files, but are managed by systemd.
polarathene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My system crashed during this review, I am accessing via phone where thankfully github has persisted what I had.
It's incomplete but will have to do for now. I may be slow to respond due to this event. Please don't merge until I return as config section will need some revision too.
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
Lost space
|
@RoelSG please also add a short entry in our |
|
I'll have time for returning to this within 48 hours. I need to spin up a VPS and verify some of the contribution to complete my review. |
polarathene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to wrap up some notes on the config section, then I'll provide some revision for the related docs. Sharing what I have so far in the meantime.
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
- Minor revisions to current PR content. - Link refs shifted to bottom of document. - "Rootfull" => "Rootful" correction.
- Better document differences between `pasta` and `slip4netns`. - Initial revision on Quadlet example section: - `network-online.target` wants/after requirements are implicit. No need to add this. - `Network=pasta` not required from Podman 5.0. - `HostName` should match config elsewhere in docs as `mail.example.com`.
|
Apologies for the delay, I had a stressful end of October that led to a burn out. I've committed the bulk of what I had managed prior to the burn out. I'll go over the current state as I recall I had a few more parts I wanted to address and polish up, then we can get this approved and merged 🚀 |
|
Sorry about the lack of activity here, bit pre-occupied elsewhere but will return to this in the 2nd half of the month. |
|
Not a problem, this is not a bugfix or something, I'll check in periodically. |
polarathene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through stuff I've had open, came across these changes which AFAIK were going towards a final revision until I had to put that on hold. I'll apply what I have here as at a glance it does seem to be an improvement overall.
I am relocating presently but still plan to investigate the concern with network drivers I had so that this can finally get wrapped up (hopefully later this month 😓)
Additionally bring the deprecation notice into this section.
|
I resolved the merge conflicts for this PR, as I'd like to get it merged. @polarathene what's the status here - can we ship this update? I do not need everything to be polished right away - if the gist is good, we can build on that. |
|
I am presently unable to context shift back to this PR, there may be some concerns with the current state of it where I wanted to revise the content or verify. I recall some claims regarding the networking drivers that might be inaccurate in the scope of the two discussed or rootless vs rootful contexts. So while I'm a little iffy about merging an incomplete update, I still think this information is valuable to our users and we'll need to defer to future contributions to correct any oversights as I'm unsure when I'll have time to prioritize this on the backlog. I will merge the PR in it's current state and add a reference to my TODO issue. |
polarathene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I've refined it as best I could with the time I had to spare.
The information should be quite helpful to Podman users and for maintainers to grok when necessary.
|
Documentation preview for this PR is ready! 🎉 Built with commit: ee8d4b0 |
Review feedback was applied long ago.
Generate systemd is deprecated and Quadlets are now used. I have spent some time getting Quadlet to work, so I added some findings to the documentation. It is my first time contributing to documentation, so excuse my English if it comes across a bit rambly.
I have only added information, and have not removed any. However, generate-systemd is now deprecated and slirp4netns is out in favour of pasta. Pasta in particular is a lot easier to configure, but is still complicated to include into a docker-compose, which I do not use anymore.
Using podlet you can also translate a docker-compose to a Quadlet. Quadlets themselves behave a lot like individual compose files, but are managed by systemd.
Checklist
docs/)CHANGELOG.md