Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix incorrect link in README.md #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperklein merged 1 commit into from
Sep 18, 2024
Merged

fix: fix incorrect link in README.md #4184

casperklein merged 1 commit into from
Sep 18, 2024

Conversation

@GallowsDove
Copy link
Contributor

@GallowsDove GallowsDove commented Sep 18, 2024

Description

Fix currently dead link for quota documentation
from: https://docker-mailserver.github.io/docker-mailserver/latest/config/account-management/overview/#quotas
to: https://docker-mailserver.github.io/docker-mailserver/latest/config/user-management/#quotas

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@GallowsDove
Copy link
Contributor Author

GallowsDove commented Sep 18, 2024

not sure if this should be included in changelog

casperklein
casperklein approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@casperklein casperklein merged commit 84180f8 into docker-mailserver:master Sep 18, 2024
@polarathene
Copy link
Member

polarathene commented Sep 18, 2024 •
edited
Loading

It's actually the correct link for the next release, so we should probably have a PR to revert this that isn't merged until we're about to release 😅

I opened a tracking issue for it with the milestone, that'll suffice for the time being so whomever manages the next release will have it visible in the milestone view 👍

@polarathene polarathene mentioned this pull request Sep 18, 2024
Closed
georglauterbach added a commit that referenced this pull request Jan 18, 2025
@georglauterbach
Revert "fix: fix incorrect link in README.md (#4184)"
ca09dc4 
This reverts commit 84180f8.
georglauterbach added a commit that referenced this pull request Jan 18, 2025
@georglauterbach
Revert "fix: fix incorrect link in README.md (#4184)" (#4322)
3ebca5d 
This reverts commit 84180f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GallowsDove @polarathene @casperklein