Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Avoid alias being used as regex during dovecot dummy account userdb detection #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polarathene merged 4 commits into from
Oct 11, 2024
Merged

fix: Avoid alias being used as regex during dovecot dummy account userdb detection #4222

polarathene merged 4 commits into from
Oct 11, 2024

Conversation

@pitilux
Copy link
Contributor

@pitilux pitilux commented Oct 10, 2024 •
edited by polarathene
Loading

Description

Fixes #4170 and test coverage of #2640.

This is my first PR, let me know if I missed something. And regarding the CHANGELOG, would the following line be ok?

Fixes
- Dovecot:
   - Fix dummy account creation (PR number)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@pitilux pitilux mentioned this pull request Oct 10, 2024
Closed
1 task
polarathene
polarathene requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to tackle this 😁

@polarathene polarathene changed the title Fix Dovecot dummy account creation fix: Avoid alias being used as regex during dovecot dummy account userdb detection Oct 10, 2024
@polarathene

This comment was marked as outdated.

Sign in to view
@polarathene polarathene added this to the v15.0.0 milestone Oct 10, 2024
@georglauterbach georglauterbach self-requested a review October 10, 2024 22:50
pitilux added 2 commits October 11, 2024 07:49
@pitilux
Copy link
Contributor Author

pitilux commented Oct 11, 2024

Thanks for the review. I applied all your suggested changes.

polarathene
polarathene approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😎

@polarathene polarathene merged commit 34eb54a into docker-mailserver:master Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach Awaiting requested review from georglauterbach

Assignees

@pitilux pitilux

Labels

area/scripts area/tests kind/bug/fix A fix (PR) for a confirmed bug service/dovecot

Projects

None yet

Milestone

v15.0.0

Development

Successfully merging this pull request may close these issues.

bug report: start-mailserver.sh says the alias will not be added twice

2 participants

@pitilux @polarathene