-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: SASLAuth - Drop services for mysql, shadow, pam auth mechanisms
#4259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
polarathene
merged 6 commits into
docker-mailserver:master
from
polarathene:fix/saslauthd-drop-invalid-mysql-config
Nov 20, 2024
Merged
fix: SASLAuth - Drop services for mysql, shadow, pam auth mechanisms
#4259
polarathene
merged 6 commits into
docker-mailserver:master
from
polarathene:fix/saslauthd-drop-invalid-mysql-config
Nov 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarathene
commented
Nov 10, 2024
mysql, shadow, pam auth mechanisms
polarathene
commented
Nov 10, 2024
casperklein
approved these changes
Nov 10, 2024
Member
Author
|
Heads-up, do not merge this PR. It's waiting on @pwntester for advice (if any), relating to our CI docs preview no longer working for PRs coming from forks: #4247 (comment) EDIT: Resolved and verified by #4267 |
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: cefc1d8 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SASLAUTHD_MECHANISMSonly has test coverage forldapandrimap, which were discussed during the original implementation of the feature.The other mechanisms were added for the sake of it, but likely don't make much sense with DMS.
pamwould as it appears to be the way to leverage databases likemysqlfor authentication.mysqlhas not been a valid value for well over a decade. It's likely never worked in DMS.Generally
SASLAUTHDrelated support is not necessary for users. It was contributed as an alternative SASL auth method for Postfix to use when DMS has Dovecot disabled that would normally be delegated for SASL authentication.Users interested in MySQL or similar DB access could configure for such directly with Postfix and Dovecot (or just Dovecot due to existing SASL auth config).
There may be potential breakage with
SMTP_ONLY=1users. I've not considered this as our support/docs for such are lacking. As this is for a breaking release, it should be fine and we can easily bring these back should users raise issues about it.Docs wise, I don't see how the note about multiple values for mechanisms being supported was valid. Perhaps it was for direct usage of the command but not with how we start the supervisord services.
Fixes #4251
UPDATE: I forgot to remove these values from our reference ENV file,
mailserver.env. This has been spotted and contributed: #4472Type of change
Checklist
docs/)CHANGELOG.md