-
-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: Migrate dovecot config from Dockerfile #4350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate dovecot config from Dockerfile #4350
Conversation
|
Additional context. I've also removed the quote wrapping around the value of
|
|
This was opened against the v15.0.0 milestone. Do you think you can cram this in? It is probably fine because we are waiting on the ClamAV CVE fix, right? |
Yeah this change should be fairly minor. There's no rush to get this change in, just a drive-by improvement while I was looking into something else. I can add a changelog entry if you like, but logically nothing should have really changed, just shifting around the same logic and improving the sed expression. Although |
Description
I noticed the
postmaster_addressline looked odd in the Dockerfile, and that we actually run it properly in our startup scripts (it's been in scripts for over 5 years). That motivated this PR.The protocol line was likewise migrated to be grouped with the related script lines with some minor revision.
The other 3 lines from the Dockerfile were all LDA specific which we haven't used since prior to DMS v2 (2016?), actually no I think we switched from Courier to Dovecot for v2, and then there was a switch from LDA to LMTP when around when LDAP support was contributed (2016H2 or 2017 IIRC, EDIT: LDA to LMTP in Oct 2016). Anyway LDA is still technically relevant for supporting Getmail at least I think, and anything else that might call
/usr/lib/dovecot/deliverto give mail to Dovecot directly.I've included some extensive commentary inline since these settings at least for
hostnameandpostmaster_addressdon't seem to be specific to LDA, that's just where they were placed in the Dovecot example configs we've copied. Dovecot 2.4 has removed those, so this will at least keep awareness of the original source until a maintainer/contributor addresses the TODO and we've migrated to 2.4 in a future base image update.No changelog entry as this did not seem like a change that is user facing, it's effectively just shifting some commands around. I have altered the sed expressions into what should be easier to grok, along with only doing a single write/update to the file. I've manually tested the sed command to ensure it still works as intended 👍