fix: include all files in change detection of Rspamd #4418
Conversation
| # Check whether Rspamd is used and if so, monitor it's changes as well | ||
| if [[ ${ENABLE_RSPAMD} -eq 1 ]] && [[ -d ${RSPAMD_DMS_D} ]]; then | ||
| readarray -d '' STAGING_FILES_RSPAMD < <(find "${RSPAMD_DMS_D}" -type f -name "*.sh" -print0) | ||
| readarray -d '' STAGING_FILES_RSPAMD < <(find "${RSPAMD_DMS_D}" -type f \( -name '*.sh' -or -name '*.conf' \) -print0) |
There was a problem hiding this comment.
What .sh files are be monitored? Nothing stood out from the docs or related check-for-changes.sh rspamd section.
There was a problem hiding this comment.
I think it's only *.conf files, really. I don't even know why we started off with *.sh in the first place?
There was a problem hiding this comment.
I don't even know why we started off with
*.shin the first place?
You're the one who contributed it 😆 (the specific commit, and linked comment reference don't provide context to the .sh relevance)
This was back in Oct 2023 (for DMS v13 in Nov 2023), I don't think @casperklein or myself were particularly thorough with reviews for rspamd beyond basics there as you were iterating through initial Rspamd support (introduced since DMS v12 in April 2023).
If you're sure that there was some mistake with .sh there, or some change where we no longer rely upon it, perhaps it can be dropped for 15.0.1 release too 🤔 It is just change detection support for something that shouldn't realistically be changing much once deployed in production, so I think it'd be safe to drop it even if you're not sure why you added it.
*.conf files in change detection of Rspamd|
Chore or fix? 🤔 |
Description
Include
*.conffiles when checking for changes in the Rspamd configuration.Fixes #4397
Type of change
Checklist
docs/)CHANGELOG.md