-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add S3-based source and target support with enhanced extensibility #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
09785ef to
9c20a94
Compare
|
There isn't a way to use a "real" docling-serve instance to use s3 source/target without a full Docling environment with Kubeflow set up (see docling-project/docling-serve#462). Because of this, in the tests I wrote I used wiremock just to verify that the request payload "looked" correct. I really have no way to test whether or not the thing actually works, like I do with all the other tests. I tried using testcontainers & Localstack, but docling itself requires a kubeflow setup running on kubernetes. I can't replicate that in a simple test. |
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
- Introduced `S3Source` and `S3Target` for S3-based document processing. - Refactored chunking request hierarchy for better reusability. - Added test coverage for S3 workflow validation. - Updated `DoclingServeApi` to support S3 credentials and configuration. - Enhanced documentation to include S3-based examples. Fixes docling-project#254 Signed-off-by: Eric Deandrea <[email protected]>
- Introduced `S3Source` and `S3Target` for S3-based document processing. - Refactored chunking request hierarchy for better reusability. - Added test coverage for S3 workflow validation. - Updated `DoclingServeApi` to support S3 credentials and configuration. - Enhanced documentation to include S3-based examples. Fixes docling-project#254 Signed-off-by: Eric Deandrea <[email protected]>
6892f7b to
cf29166
Compare
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
🎉 This issue has been resolved in |
S3SourceandS3Targetfor S3-based document processing.DoclingServeApito support S3 credentials and configuration.Fixes #254