apps/server/src/core/space/services/space.service.ts (1)

108-117: Add validation for homePageId before persisting.

The service persists homePageId without validating that:

1. The page actually exists
2. The page belongs to the space being updated

This could allow setting a non-existent page or a page from a different space as the home page, leading to broken navigation and data integrity issues.

Add validation before the update. Example implementation:

async updateSpace(
  updateSpaceDto: UpdateSpaceDto,
  workspaceId: string,
): Promise<Space> {
  if (updateSpaceDto?.slug) {
    const slugExists = await this.spaceRepo.slugExists(
      updateSpaceDto.slug,
      workspaceId,
    );

    if (slugExists) {
      throw new BadRequestException(
        'Space slug exists. Please use a unique space slug',
      );
    }
  }

  // Validate homePageId if provided
  if (updateSpaceDto?.homePageId) {
    const page = await this.pageRepo.findById(
      updateSpaceDto.homePageId,
      workspaceId,
    );
    
    if (!page || page.spaceId !== updateSpaceDto.spaceId) {
      throw new BadRequestException(
        'Invalid home page: page does not exist or does not belong to this space',
      );
    }
  }

  return await this.spaceRepo.updateSpace(
    {
      name: updateSpaceDto.name,
      description: updateSpaceDto.description,
      slug: updateSpaceDto.slug,
      homePageId: updateSpaceDto.homePageId
    },
    updateSpaceDto.spaceId,
    workspaceId,
  );
}

apps/client/src/features/page/components/header/page-header-menu.tsx (1)

55-105: Guard optional props before mutating space state

isHome, spaceId, and pageId are all optional yet the new logic assumes they are defined. Today this compiles because the props are typed as optional, but at runtime we immediately feed them into useState<boolean>(isHome) and setIsHomePage(isHome) (Line 67 / Line 103). When isHome is undefined (the default for spaces without a home page), React receives undefined where a boolean is required. TypeScript also rejects this under strictNullChecks, so the build will break.

Additionally, when the user marks a page as the home page, we send { homePageId: pageId }. If pageId or spaceId is missing (which can happen because they are optional), we end up hitting the mutation with undefined, leading to a backend validation error and leaving the UI out of sync.

Please normalise the props before use (default isHome to false) and bail out early if either spaceId or pageId is missing so we never fire an invalid update. Example fix:

-const [isHomePage, setIsHomePage] = useState<boolean>(isHome);
+const [isHomePage, setIsHomePage] = useState<boolean>(Boolean(isHome));
…
-const handleUpdateHomePage = async () => {
-  const newHomePageValue = isHomePage ? null : pageId;
-  const spaceData: Partial<ISpace> = {
-    spaceId: spaceId,
-    homePageId: newHomePageValue,
-  };
-
-  await updateSpaceMutation.mutateAsync(spaceData);
-  setIsHomePage(!isHomePage);
-};
+const handleUpdateHomePage = async () => {
+  if (!spaceId || !pageId) {
+    return;
+  }
+
+  const newHomePageValue = isHomePage ? null : pageId;
+  await updateSpaceMutation.mutateAsync({
+    spaceId,
+    homePageId: newHomePageValue,
+  });
+  setIsHomePage((current) => !current);
+};
…
-useEffect(() => {
-  setIsHomePage(isHome);
-}, [isHome]);
+useEffect(() => {
+  setIsHomePage(Boolean(isHome));
+}, [isHome]);

This keeps state strictly boolean and prevents accidental mutation calls with undefined identifiers.