fix(client): ensure sidebar remains visible on shared subpages#1887
Open
MatheusLuisLorscheiter wants to merge 2 commits intodocmost:mainfrom
Open
fix(client): ensure sidebar remains visible on shared subpages#1887MatheusLuisLorscheiter wants to merge 2 commits intodocmost:mainfrom
MatheusLuisLorscheiter wants to merge 2 commits intodocmost:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This pull request fixes a navigation issue where the sidebar would disappear when viewing shared subpages. The fix adds logic to check if a page is part of the active shared tree before redirecting, ensuring the sidebar remains visible when navigating between related shared pages.
Changes:
- Added a check to prevent redirecting when the current page is part of the shared tree structure
- Implemented a new utility function
isPageInTreeto recursively search for pages in the tree - Modified the navigation logic in SharedPage component to conditionally redirect based on tree membership
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/client/src/pages/share/shared-page.tsx | Modified navigation logic to check tree membership before redirecting, preserving sidebar visibility |
| apps/client/src/features/share/utils.ts | Added isPageInTree utility function for recursive tree traversal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.