fix: resolve keystroke input being swallowed after link in Firefox#1922
Open
olivierlambert wants to merge 2 commits intodocmost:mainfrom
Open
fix: resolve keystroke input being swallowed after link in Firefox#1922olivierlambert wants to merge 2 commits intodocmost:mainfrom
olivierlambert wants to merge 2 commits intodocmost:mainfrom
Conversation
In Firefox, when the cursor is at the right boundary of a link mark, contenteditable inserts new text inside the <a> element. ProseMirror then rejects the DOM mutation because the link mark has inclusive: false, causing keystrokes to be silently swallowed. Unlike Chrome, Firefox also does not fire ProseMirror's handleTextInput callback in this state. This adds a ProseMirror plugin that intercepts printable character keydowns at link mark boundaries and programmatically inserts the text without the link mark, bypassing Firefox's native contenteditable behavior entirely. Fixes docmost#1773 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
|
Extend the linkBoundaryInput plugin to also handle the left boundary of links, where the cursor is just before a link (e.g. at the start of a line). Firefox inserts text inside the <a> element in this case too, causing ProseMirror to reject the mutation. Fixes docmost#1748 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Firefox, when the cursor is at the right boundary of a link mark, contenteditable inserts new text inside the element. ProseMirror then rejects the DOM mutation because the link mark has inclusive: false, causing keystrokes to be silently swallowed. Unlike Chrome, Firefox also does not fire ProseMirror's handleTextInput callback in this state.
This adds a ProseMirror plugin that intercepts printable character keydowns at link mark boundaries and programmatically inserts the text without the link mark, bypassing Firefox's native contenteditable behavior entirely.
Fixes #1773
Note: functionally tested. Before: bug visible only in Firefox. Now the bug is fixed in Firefox without any regression on Chrome.
edit: now improved via a 2nd commit to fix #1748 at the same time.