Always warn on plugin skip, improve keyword msg#903
Closed
theinternetftw wants to merge 1 commit intodocpad:masterfrom
theinternetftw:better-plugin-warning
Closed
Always warn on plugin skip, improve keyword msg#903theinternetftw wants to merge 1 commit intodocpad:masterfrom theinternetftw:better-plugin-warning
theinternetftw wants to merge 1 commit intodocpad:masterfrom
theinternetftw:better-plugin-warning
Conversation
Contributor
|
lgtm 👍 |
Member
|
The reasoning why this is debug only is that if you have node dependencies used (not just docpad plugins, e.g. Perhaps we can tweak this. What reason did DocPad say for skipping your plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was really distressing to have docpad silently ignore a plugin after a few small changes. A plugin skip should always be overt.
I also tweaked the reason given to be a little more descriptive than "type".