Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: add stormkit as deployment platform #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2024
Merged

docs: add stormkit as deployment platform #2413

merged 2 commits into from
May 7, 2024

Conversation

eldemcan
Copy link
Contributor

Summary

Add stormkit as deployment platform

Related issue, if any:

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:06pm

@paulhibbitts
Copy link
Collaborator

Thanks for the PR @eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

@paulhibbitts paulhibbitts self-assigned this Apr 29, 2024
@eldemcan
Copy link
Contributor Author

Thanks for the PR @eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

Hi @paulhibbitts
Thanks for looking into this PR, I updated step to set output folder to docs.

@paulhibbitts paulhibbitts self-requested a review April 30, 2024 14:48
paulhibbitts
paulhibbitts reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@paulhibbitts paulhibbitts added the docs related to the documentation of docsify itself label Apr 30, 2024
@eldemcan eldemcan requested a review from paulhibbitts May 6, 2024 18:06
@eldemcan
Copy link
Contributor Author

eldemcan commented May 6, 2024

Hi @paulhibbitts, is there anything I need to do before this is merged ?

sy-records
sy-records approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@sy-records sy-records merged commit 11015fe into docsifyjs:develop May 7, 2024
4 checks passed
@paulhibbitts
Copy link
Collaborator

Thanks for merging the PR @sy-records!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sy-records sy-records sy-records approved these changes

@paulhibbitts paulhibbitts Awaiting requested review from paulhibbitts

Assignees

@paulhibbitts paulhibbitts

Labels
docs related to the documentation of docsify itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldemcan @paulhibbitts @sy-records