Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding Spanish #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2018
Merged

Adding Spanish #489

merged 1 commit into from
May 17, 2018

Conversation

SidVal
Copy link
Member

@SidVal SidVal commented May 17, 2018

Fix: #484

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li QingWei-Li merged commit 2d9e581 into docsifyjs:master May 17, 2018
@jrappen
Copy link
Contributor

jrappen commented Jul 1, 2018 •
edited
Loading

@SidVal Two thoughts on SidVal/docsify-es:

  • Why separate the Spanish docs from the main repo? There isn't even a reference to your derivative in the Spanish docs.
  • Please check the MIT License requirements applying to your derivative.
  • Could you update the Spanish docs?

Edit:

It seems QingWei is setting up single repos for the languages at:

https://github.com/docsifyjs

@SidVal
Copy link
Member Author

SidVal commented Jul 1, 2018 •
edited
Loading

Hi @jrappen .

  1. I separated docs because @QingWei-Li told me. I think he explain this here.
  2. I can not understand what are you saying about MIT Licence.
  3. Done.

@jrappen
Copy link
Contributor

jrappen commented Jul 2, 2018

@SidVal Have a look at the license text where it says:

docsify/LICENSE

Lines 12 to 13 in 3a72074

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

This page might help, too:

https://choosealicense.com/licenses/mit/

This was referenced Dec 28, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 8, 2022
Open
@skmezanul skmezanul mentioned this pull request Jan 9, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SidVal @jrappen @QingWei-Li