Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix .gitattribute #540

Merged
greg0ire merged 1 commit into
doctrine:3.4.xfrom
connorhu:fix/gitattributes-fix
Apr 9, 2024
Merged

Fix .gitattribute #540
greg0ire merged 1 commit into
doctrine:3.4.xfrom
connorhu:fix/gitattributes-fix

Conversation

@connorhu
Copy link
Copy Markdown
Contributor

@connorhu connorhu commented Apr 8, 2024

Mostly fixes because of #535

  • updated Tests
  • removed phpstan neon
  • added phpstan baseline
  • added docs

@connorhu connorhu changed the base branch from 3.3.x to 3.4.x April 8, 2024 09:33
@connorhu connorhu marked this pull request as ready for review April 8, 2024 09:34
@connorhu
Copy link
Copy Markdown
Contributor Author

connorhu commented Apr 8, 2024

A couple of weeks ago I was playing around with the problem of whether there is any way to check the export-ignore setting with "deny all".
I ended up with a GHA task, but I'm not completely satisfied with it yet (I'm not a git wizard).

In a file it was listed what was allowed in the root directory and in case of PR a job checked if the ones in the root were allowed.

@connorhu connorhu closed this Apr 8, 2024
@connorhu connorhu reopened this Apr 8, 2024
@SenseException
Copy link
Copy Markdown
Member

Thanks for the contribution. Could you please squash your commits?

@connorhu connorhu force-pushed the fix/gitattributes-fix branch from c3479e5 to aa01ff1 Compare April 9, 2024 05:37
@connorhu
Copy link
Copy Markdown
Contributor Author

connorhu commented Apr 9, 2024

@SenseException Sure!

@greg0ire greg0ire merged commit 3c5fbf9 into doctrine:3.4.x Apr 9, 2024
@greg0ire greg0ire added this to the 3.4.0 milestone Apr 9, 2024
@greg0ire greg0ire added the Bug label Apr 9, 2024
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Apr 9, 2024

Thanks @connorhu !

@connorhu connorhu deleted the fix/gitattributes-fix branch April 9, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants