Drop unsupported versions of PHP#571
Merged
Merged
Conversation
d1bbc00 to
b6f94d9
Compare
greg0ire
commented
Jan 12, 2025
| "doctrine/persistence": "^2.0 || ^3 ", | ||
| "symfony/phpunit-bridge": "^6.3 || ^7", | ||
| "symfony/var-exporter": "^5.4 || ^6 || ^7" | ||
| "symfony/console": "^6.4.17", |
Member
Author
There was a problem hiding this comment.
Had to add this constraint because of an indirect deprecation that caused the prefer-lowest job to fail.
Member
There was a problem hiding this comment.
So we're not testing with Console 7? That would be really bad.
Member
Author
There was a problem hiding this comment.
Oh yeah sorry, I will add it.
2139686 to
2620407
Compare
derrabus
approved these changes
Jan 12, 2025
Member
derrabus
left a comment
There was a problem hiding this comment.
I've merged up your changes on 3.3.x. If you want, you can rebase and throw PHPStan 1 our of composer.json.
This should allow us to do many breaking changes related to new features of PHP. I'm bumping to 8.1 and not higher for the sake of consistency with other recent versions of Doctrine packages. I am dropping some old versions of some require-dev dependencies that are not optional dependencies in the hope of having the prefer-lowest build pass.
2620407 to
df4b11b
Compare
derrabus
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to do many breaking changes related to new features of PHP.
I'm buping to 8.1 and not higher for the sake of consistency with other recent versions of Doctrine packages. Do let me know if you think I should bump higher.