Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Address newly detected PHPStan issues#606

Merged
greg0ire merged 3 commits into
doctrine:3.4.xfrom
greg0ire:fix-build
Sep 2, 2025
Merged

Address newly detected PHPStan issues#606
greg0ire merged 3 commits into
doctrine:3.4.xfrom
greg0ire:fix-build

Conversation

@greg0ire
Copy link
Copy Markdown
Member

@greg0ire greg0ire commented Sep 1, 2025

No description provided.

@greg0ire greg0ire mentioned this pull request Sep 1, 2025
Merged
@greg0ire
Copy link
Copy Markdown
Member Author

greg0ire commented Sep 1, 2025 •
edited
Loading

@derrabus @stof the remaing issue about build_dir seems to be related to Symfony 🤔
Do you maybe know about this?

Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException: The parameter "doctrine.orm.proxy_dir" has a dependency on a non-existent parameter "kernel.build_dir". Did you mean one of these: "kernel.cache_dir", "kernel.root_dir"?

stof
stof reviewed Sep 1, 2025
View reviewed changes
Comment thread src/EventListener/SchemaFilterListener.php Outdated
/**
* @param AbstractAsset|string $asset
*
* @phpstan-ignore missingType.generics (a listener should receive all types of assets)
Copy link
Copy Markdown
Member

@stof stof Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper way would be to use AbstractAsset<*> (where phpstan will then properly check that the logic actually supports any kind of asset)

@stof
Copy link
Copy Markdown
Member

stof commented Sep 1, 2025

@greg0ire DoctrineMigrationsExtensionTest is creating its own ContainerBuilder to run the unit tests of the extension. It is not a ContainerBuilder managed by the Kernel. The parameters defined by the Kernel are defined in DoctrineMigrationsExtensionTest::getContainerBuilder to "mock" them (sort of), but kernel.build_dir is indeed not defined there.

@greg0ire greg0ire merged commit 5a81825 into doctrine:3.4.x Sep 2, 2025
15 checks passed
@greg0ire greg0ire added this to the 3.4.3 milestone Sep 2, 2025
@github-actions github-actions Bot mentioned this pull request Oct 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SenseException SenseException SenseException approved these changes

@stof stof Awaiting requested review from stof

@derrabus derrabus Awaiting requested review from derrabus

Assignees

No one assigned

Labels

Static Analysis

Projects

None yet

Milestone

3.4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@greg0ire @stof @SenseException