Reproduce dots in quted names #7031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a31939 to
d7ff279
Compare
|
The underlying issue was fixed here: 92dea81 Not sure if it makes sense to add the test case just to not accidentally break the behaviour again anyway I don't know why setting the FK on DB2 and Oracle DBs fails, happy for any insights how to fix |
morozov
reviewed
Sep 21, 2025
| public function testIntrospectTableWithDotInIndexNames(): void | ||
| { | ||
| $table = Table::editor() | ||
| ->setQuotedName('test_user') |
There was a problem hiding this comment.
I don't know why setting the FK on DB2 and Oracle DBs fails, happy for any insights how to fix
You declare the table name here as quoted but reference it in the other table as unquoted:
On Oracle and Db2, "test_user" (quoted) remains test_user, while test_user (unquoted) becomes TEST_USER. Hence the error message:
"DB2INST1.TEST_USER" is an undefined name
Unless you want to retain the original case of the name on all platforms, you should use unquoted names.
d7ff279 to
83144b1
Compare
Otherwise, an extra "not null" assertion is required before comparing the value returned by OptionallyNamedObject::getObjectName() with the expected one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide test for dots in quoted idx names