Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correct pluralization of axis#241

Merged
malarzm merged 1 commit into
doctrine:2.0.xfrom
iurciuc:2.0.x
Jan 15, 2024
Merged

Correct pluralization of axis#241
malarzm merged 1 commit into
doctrine:2.0.xfrom
iurciuc:2.0.x

Conversation

@iurciuc
Copy link
Copy Markdown

@iurciuc iurciuc commented Jan 12, 2024

@malarzm
Copy link
Copy Markdown
Member

malarzm commented Jan 12, 2024

@iurciuc thanks for your PR! I'm afraid we have a hard nut to crack here as per the tests: axes was previously singularized to axe and after your change no longer is. I can't really see a way forward as fixing your bug means breaking something that worked before :/

@malarzm
Copy link
Copy Markdown
Member

malarzm commented Jan 12, 2024

Theoretically we could fix axis -> axes and still have axes -> axe as the lib has no way of knowing what word it should singularize into. Thoughts?

@iurciuc
Copy link
Copy Markdown
Author

iurciuc commented Jan 13, 2024

In 99% of cases axes->axe will be what user expected!
To be consistent(English in this case is not so consistent) we can build a feature to provide possibility to extend the logic of this lib by a config.

@malarzm
Copy link
Copy Markdown
Member

malarzm commented Jan 13, 2024

I think config is an overkill in this case :) Let's proceed with fixing axis -> axes but keeping axes -> axe

@iurciuc
Copy link
Copy Markdown
Author

iurciuc commented Jan 15, 2024

Fixed

@malarzm malarzm added this to the 2.0.9 milestone Jan 15, 2024
@malarzm malarzm merged commit 2930cd5 into doctrine:2.0.x Jan 15, 2024
@malarzm
Copy link
Copy Markdown
Member

malarzm commented Jan 15, 2024

Thanks @iurciuc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants