Conversation
Using a pipe to mean "and" is a legacy of a time where & was not understood by tooling.
Member
Author
|
I noticed that doing this allows us to bump the PHPStan level to 10 without any other modification. But just because we can does not mean we should. Let me know what you think. In any case, it could be done in a subsequent PR. |
SenseException
approved these changes
Jul 29, 2025
Member
SenseException
left a comment
There was a problem hiding this comment.
I don't mind if level 10 will be introduced in this or another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while converting the codebase to PHP 8.4. Static analysis is OK with this when it is in a phpdoc comment, but not as a property.
Using a pipe to mean "and" is a legacy of a time where & was not understood by tooling.