[GH-7486] Bugfix: failing the command when clearing empty cache is wrong semantics. (#8376)

beberlei · web-flow · commit 21d2c880136a · 2020-12-06T22:00:00.000+01:00
diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php
@@ -99,12 +99,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $message = ($result) ? 'Successfully flushed cache entries.' : $message;
         }
 
-        if ( ! $result) {
-            $ui->error($message);
-
-            return 1;
-        }
-
         $ui->success($message);
 
         return 0;
diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php
@@ -98,12 +98,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $message = ($result) ? 'Successfully flushed cache entries.' : $message;
         }
 
-        if ( ! $result) {
-            $ui->error($message);
-
-            return 1;
-        }
-
         $ui->success($message);
 
         return 0;
diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php
@@ -99,12 +99,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $message = ($result) ? 'Successfully flushed cache entries.' : $message;
         }
 
-        if ( ! $result) {
-            $ui->error($message);
-
-            return 1;
-        }
-
         $ui->success($message);
 
         return 0;
