[GH-7486] Bugfix: failing when clearing empty cache is wrong semantics#8376
Merged
beberlei merged 1 commit intoDec 6, 2020
Merged
Conversation
…he is wrong semantics.
greg0ire
approved these changes
Dec 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you call clear cache on result, query, metadata caches, then clearing an empty cache is also semantically clearing the cache. As such it should not fail with an error as it currently does. This could be considered a BC break, but this behavior is completly bogus, so I consider it a bug to be fixed.
Fixes #7486