Address new behavior of $firstResult#10365
Merged
Merged
Conversation
Following 1915dcd, 0 is now used as a default value, and Query::$firstResult is no longer nullable, but it seems getFirstResult() was overlooked. The class is final, so this is no breaking change.
SenseException
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #9730,
0is now used as a default value, andQuery::$firstResultis no longer nullable, but it seemsgetFirstResult()was overlooked. The class is final, so this is no breaking change. Found by Rector while working on the PHP 8 migration.