Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reuse association mapping array shape#10403

Merged
derrabus merged 1 commit into
doctrine:2.15.xfrom
greg0ire:array-shape
Jan 17, 2023
Merged

Reuse association mapping array shape#10403
derrabus merged 1 commit into
doctrine:2.15.xfrom
greg0ire:array-shape

Conversation

@greg0ire
Copy link
Copy Markdown
Member

No description provided.

@mpdude
Copy link
Copy Markdown
Contributor

mpdude commented Jan 15, 2023

May I ask why such changes are made on 2.15, not on 2.14?

I understand that 2.14 is the current bugfix branch, and this is not a bugfix.

The idea of separating bugfix from feature branches (as I get it) is to avoid as many changes as possible on the bugfix one, to avoid the risk of unintentional breakage.

A change like this one here, however, does not change the running code, does it? It only improves static analysis capabilities and thus might be helpful for people fixing things on 2.14?

So why not merge such changes there?

@greg0ire
Copy link
Copy Markdown
Member Author

It might break static analysis on a downstream project. I use 2.14.x for phpdoc that is wrong. The current annotations are vague but not wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants