Reuse association mapping array shape#10403
Merged
Merged
Conversation
mpdude
approved these changes
Jan 14, 2023
Contributor
|
May I ask why such changes are made on 2.15, not on 2.14? I understand that 2.14 is the current bugfix branch, and this is not a bugfix. The idea of separating bugfix from feature branches (as I get it) is to avoid as many changes as possible on the bugfix one, to avoid the risk of unintentional breakage. A change like this one here, however, does not change the running code, does it? It only improves static analysis capabilities and thus might be helpful for people fixing things on 2.14? So why not merge such changes there? |
Member
Author
|
It might break static analysis on a downstream project. I use 2.14.x for phpdoc that is wrong. The current annotations are vague but not wrong |
derrabus
approved these changes
Jan 17, 2023
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.