Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle null comparisons in ManyToManyPersister#10587

Merged
derrabus merged 3 commits into
doctrine:2.14.xfrom
MatTheCat:7717_testcase
Apr 12, 2023
Merged

Handle null comparisons in ManyToManyPersister#10587
derrabus merged 3 commits into
doctrine:2.14.xfrom
MatTheCat:7717_testcase

Conversation

@MatTheCat
Copy link
Copy Markdown
Contributor

@MatTheCat MatTheCat commented Mar 21, 2023 •
edited
Loading

Fixes #5587, #5827 and #7717

The reason for

orm/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php

Lines 34 to 38 in a50a611

if (($operator === Comparison::EQ || $operator === Comparison::IS) && $value === null) {
return null;
} elseif ($operator === Comparison::NEQ && $value === null) {
return null;
}
was that BasicEntityPersister replaces null comparisons with IS [NOT] NULL so it does not need the corresponding parameter.

Problem is, ManyToManyPersister has then no longer access to the comparison.

My fix is to remove the condition in SqlValueVisitor and make each persister wary of null comparisons. It feels super weird but tests pass.

@MatTheCat MatTheCat changed the title Add test case for https://github.com/doctrine/orm/issues/7717 Handle null comparisons in ManyToManyPersister Mar 21, 2023
@MatTheCat MatTheCat mentioned this pull request Apr 12, 2023
Closed
greg0ire
greg0ire reviewed Apr 12, 2023
View reviewed changes
Comment thread tests/Doctrine/Tests/Models/GH7717/GH7717Parent.php
@greg0ire greg0ire added the Bug label Apr 12, 2023
@derrabus derrabus added this to the 2.14.3 milestone Apr 12, 2023
@derrabus derrabus merged commit fca1ef7 into doctrine:2.14.x Apr 12, 2023
@MatTheCat MatTheCat deleted the 7717_testcase branch April 12, 2023 17:26
@MatTheCat
Copy link
Copy Markdown
Contributor Author

MatTheCat commented Apr 12, 2023

Thanks! #5827 and #7717 can be closed; I thought GitHub would do it automatically.

@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Apr 12, 2023

I think you have to repeat Fixes every time for that to happen 🙂

@greg0ire greg0ire linked an issue Apr 12, 2023 that may be closed by this pull request
isNull criteria doesn't work #7717
Closed
@MatTheCat
Copy link
Copy Markdown
Contributor Author

MatTheCat commented Apr 12, 2023

Indeed, just read https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword 😅

@github-actions github-actions Bot mentioned this pull request Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus derrabus approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

2.14.3

Development

Successfully merging this pull request may close these issues.

isNull criteria doesn't work @ManyToMany relation matching criteria ignores isNull(column)

3 participants

@MatTheCat @greg0ire @derrabus