Avoid partial#10780
Merged
Merged
Conversation
It brings nothing over what PHPUnit now natively does.
deae31e to
331aff7
Compare
Partial objects are deprecated. They were handy to make the generated SQL more legible, but we should refrain from relying on them.
SenseException
approved these changes
Jun 21, 2023
Member
SenseException
left a comment
There was a problem hiding this comment.
Is this a partial change to avoid partial objects and will further changes follow? This PR just changes a test class on line that contained ORMQuery::HINT_FORCE_PARTIAL_LOAD
Member
Author
lol I see what you did here 😉 There might be more PRs against 2.15.x, if I notice more tests need to be migrated while attempting to remove PARTIAL from 3.0.x IIRC this was the biggest source of changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial objects are deprecated. They were handy to make the generated
SQL more legible, but we should refrain from relying on them.