Add dummy title to the sidebar before checking docs#10824
Merged
Conversation
The way we have our docs, the sidebar is a separate document and as such, needs a title. Let us prepend a dummy title until the guides-cli provides a way to ignore that particular error.
Member
|
What's the result of the change? That "Dummy Page" will be shown? |
Member
Author
|
The result of this change is the disappearance of a warning about the title missing, and affects only the CI. It doesn't impact what is show on the website, since that dummy title is never under version control. I've discussed this people @linawolf, and she told me the right way to fix this will be to handle the |
SenseException
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we have our docs, the sidebar is a separate document and as such, needs a title. Let us prepend a dummy title until the guides-cli provides a way to ignore that particular error.