Add possibility to set reportFieldsWhereDeclared in ORMSetup#10865
Merged
Conversation
Otherwise it is impossible to avoid a deprecation warning when using ORMSetup::createAttributeMetadataConfiguration()
Member
|
Thank you. I agree that we should treat this as a bugfix. @mpdude WDYT? |
derrabus
approved these changes
Aug 2, 2023
Contributor
|
Agree. Seems I added the flag in |
derrabus
added a commit
that referenced
this pull request
Aug 7, 2023
* 2.16.x: Turn identity map collisions from exception to deprecation notice (#10878) Add possibility to set reportFieldsWhereDeclared to true in ORMSetup (#10865) Fix UnitOfWork->originalEntityData is missing not-modified collections after computeChangeSet (#9301) Add an UPGRADE notice about the potential changes in commit order (#10866) Update branch metadata (#10862)
nicolas-grekas
pushed a commit
to nicolas-grekas/doctrine-orm
that referenced
this pull request
Aug 7, 2023
…octrine#10865) Otherwise it is impossible to avoid a deprecation warning when using ORMSetup::createAttributeMetadataConfiguration()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter
$reportFieldsWhereDeclaredwas introduced to theAttributeDriverin #10455 and setting it tofalseis deprecated.However,
ORMSetup::createAttributeMetadataConfiguration()doesn't provide a way to fix this warning: