Use a dedicated exception for the check added in #10785#10881
Merged
Conversation
Contributor
Author
|
I thought it might be worthwhile to extend from I am open for all suggestions regarding naming or other exception base classes. |
This adds a dedicated exception for the case that objects with colliding identities are to be put into the identity map. Implements doctrine#10872.
31f00cb to
d813432
Compare
Contributor
Author
|
@gbirke FYI |
gbirke
approved these changes
Aug 6, 2023
Contributor
gbirke
left a comment
There was a problem hiding this comment.
I like the change, esp. with the throws annotation. BC Break (No RuntimeException thrown) won’t be a problem for me
derrabus
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dedicated exception for the case that objects with colliding identities are to be put into the identity map.
Implements #10872.