Remove CommitOrderCalculator and related classes#10966
Closed
greg0ire wants to merge 1 commit into
Closed
Conversation
They are unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are unused.
The classes are internal, so I did not add an upgrade note, including for
UnitOfWork::getCommitOrderCalculator().This is a follow-up to #10547
UPDATE: In fact, I'm wondering why we are not doing this in 2.x instead. @mpdude , any idea? I created #10967 as an alternative.
Closes #10967