Allow (Array)ParameterType in QueryBuilder #11287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Feb 21, 2024
f208f3c to
edd11b6
Compare
greg0ire
reviewed
Feb 22, 2024
edd11b6 to
708146b
Compare
Member
Author
|
Thank you @hanishsingla! |
Member
Author
|
Test backported to 2.x as #11288. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #11279, fixes #11278.
This PR continues the work done by @hanishsingla and adds a few tests.
Changing the signature of
QueryBuilder::setParameter()is technically a BC break, but we cannot fix the bug without breaking BC, I'm afraid. Let's hope nobody overrides thesetParameter()method of 3.0 yet. 🤞🏻