Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "SchemaValidator: Changing mapping of BIGINT to string|int"#11415

Merged
derrabus merged 1 commit into
doctrine:3.1.xfrom
derrabus:revert/11399
Apr 15, 2024
Merged

Revert "SchemaValidator: Changing mapping of BIGINT to string|int"#11415
derrabus merged 1 commit into
doctrine:3.1.xfrom
derrabus:revert/11399

Conversation

@derrabus
Copy link
Copy Markdown
Member

I'm reverting #11399 in favor of an upmerge of #11414 which gives us a more consistent developer experience across DBAL and ORM releases.

cc @ThomasLandauer

…1377"

This reverts commit cbb6c89, reversing
changes made to 9c56071.
@derrabus derrabus added this to the 3.1.2 milestone Apr 15, 2024
@derrabus derrabus requested a review from greg0ire April 15, 2024 13:50
@derrabus derrabus merged commit 9c22814 into doctrine:3.1.x Apr 15, 2024
@derrabus derrabus deleted the revert/11399 branch April 15, 2024 14:03
@ThomasLandauer
Copy link
Copy Markdown
Contributor

So I did it in 3.1 and you did the ~same in 2.19 and now propagate/cascade/inherit it to 3.1? And this is called an upmerge? But what are "downstream projects"?

So the bottom line stays the same: This is the way to go for the future?:

#[Column(type: Types::BIGINT)]
private string|int $bigint;

@derrabus
Copy link
Copy Markdown
Member Author

So I did it in 3.1 and you did the ~same in 2.19 and now propagate/cascade/inherit it to 3.1? And this is called an upmerge?

Yes, see #11416.

But what are "downstream projects"?

Your application.

So the bottom line stays the same: This is the way to go for the future?:

#[Column(type: Types::BIGINT)]
private string|int $bigint;

That would be valid, although I personally prefer this version for my projects:

#[Column(type: Types::BIGINT)]
private int $bigint;

derrabus added a commit that referenced this pull request Apr 15, 2024
* 3.1.x:
  Revert "Merge pull request #11399 from ThomasLandauer/issue-11377" (#11415)
  Fix BIGINT validation (#11414)
  docs: update PHP version in doc
  Fix fromMappingArray definition
  Fix templated phpdoc return type (#11407)
  [Documentation] Merging "Query Result Formats" with "Hydration Modes"
  SchemaValidator: Changing mapping of BIGINT to string|int
  Fix psalm errors: remove override of template type
  Update dql-doctrine-query-language.rst
  Adding `NonUniqueResultException`
  [Documentation] Query Result Formats
derrabus added a commit that referenced this pull request Apr 15, 2024
* 3.2.x:
  Revert "Merge pull request #11399 from ThomasLandauer/issue-11377" (#11415)
  Fix BIGINT validation (#11414)
  docs: update PHP version in doc
  Fix fromMappingArray definition
  Fix templated phpdoc return type (#11407)
  [Documentation] Merging "Query Result Formats" with "Hydration Modes"
  SchemaValidator: Changing mapping of BIGINT to string|int
  Fix psalm errors: remove override of template type
  Update dql-doctrine-query-language.rst
  Adding `NonUniqueResultException`
  [Documentation] Query Result Formats
@ThomasLandauer
Copy link
Copy Markdown
Contributor

  • So "downstream projects" means just "projects that are using the ORM". And "upstream projects" doesn't exist?

  • #[Column(type: Types::BIGINT)]
    private int $bigint;

    => Cool - even better! :-)

@derrabus
Copy link
Copy Markdown
Member Author

  • So "downstream projects" means just "projects that are using the ORM". And "upstream projects" doesn't exist?

Upstream projects from the ORM's perspective would be DBAL, Persistence, Symfony VarExporter, the PHP runtime, …

=> Cool - even better! :-)

✌🏻

@derrabus derrabus added the Bug label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants