Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix#1154

Merged
deeky666 merged 6 commits into
doctrine:2.4from
Ocramius:hotfix/PHP-5.6-serialization-fix
Oct 6, 2014
Merged

DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix#1154
deeky666 merged 6 commits into
doctrine:2.4from
Ocramius:hotfix/PHP-5.6-serialization-fix

Conversation

@Ocramius
Copy link
Copy Markdown
Member

@Ocramius Ocramius commented Oct 6, 2014

See DDC-3120 ( http://www.doctrine-project.org/jira/browse/DDC-3120 )

This PR provides a backport for the 2.4 branch

@doctrinebot
Copy link
Copy Markdown

doctrinebot commented Oct 6, 2014

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3339

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius changed the title Hotfix/php 5.6 serialization fix DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix Oct 6, 2014
@Ocramius Ocramius mentioned this pull request Oct 6, 2014
Closed
deeky666 added a commit that referenced this pull request Oct 6, 2014
@deeky666
Merge pull request #1154 from Ocramius/hotfix/PHP-5.6-serialization-fix
d46fa4a 
DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix
@deeky666 deeky666 merged commit d46fa4a into doctrine:2.4 Oct 6, 2014
@Ocramius Ocramius deleted the hotfix/PHP-5.6-serialization-fix branch October 6, 2014 13:09
@dbpolito
Copy link
Copy Markdown

dbpolito commented Dec 3, 2014

Is there any chance this go to v2.3.x? I've tested and this change makes version v2.3.x works at php 5.6.

@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Dec 3, 2014

@dbpolito we don't even test 2.3 against PHP 5.5 and 5.6: not going to happen unless it's a security issue.

@dbpolito dbpolito mentioned this pull request Dec 29, 2014
Merged
@lyrixx
Copy link
Copy Markdown
Contributor

lyrixx commented Feb 17, 2015

Hi @Ocramius or @beberlei ; Could you tag a new release with this fix ? Because I want to run my project on php 5.6, and this current release prevent me to do that.

@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Feb 17, 2015

This was already tagged in 2.4.6

@lyrixx
Copy link
Copy Markdown
Contributor

lyrixx commented Feb 17, 2015

Oups, sorry for the noise.

Github did not show me the tag for this commit: a69584a

Thanks anyway ;)

@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Feb 17, 2015

@lyrixx consider that we mark the release versions in jira.

@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@deeky666 deeky666

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Ocramius @doctrinebot @dbpolito @lyrixx @stof @loicfavory @deeky666