Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add capability to use allfields sql notation#11846

Merged
greg0ire merged 1 commit into
doctrine:3.4.xfrom
eltharin:all_fields
May 8, 2025
Merged

add capability to use allfields sql notation#11846
greg0ire merged 1 commit into
doctrine:3.4.xfrom
eltharin:all_fields

Conversation

@eltharin
Copy link
Copy Markdown
Contributor

@eltharin eltharin commented Feb 21, 2025

in a dto, this PR allow to call u.* to get all fileds fo u entity in one call,

need #11825 to work

@eltharin eltharin force-pushed the all_fields branch 6 times, most recently from 1badf98 to 038734f Compare March 19, 2025 15:19
Comment thread docs/en/reference/dql-doctrine-query-language.rst Outdated
Comment thread docs/en/reference/dql-doctrine-query-language.rst Outdated
Comment thread src/Query/AST/AllFieldsExpression.php Outdated
Comment thread docs/en/reference/dql-doctrine-query-language.rst Outdated
in a dto, this PR allow to call u.* to get all fileds fo u entity in one call,
@greg0ire greg0ire added this to the 3.4.0 milestone May 8, 2025
@greg0ire greg0ire merged commit 083b241 into doctrine:3.4.x May 8, 2025
86 checks passed
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented May 8, 2025

Thanks @eltharin !

@eltharin eltharin deleted the all_fields branch June 17, 2025 08:18
@greg0ire
Copy link
Copy Markdown
Member

We are going to revert this because, to quote @beberlei

  • " it adds alias.* which is not possible in any other place, for example you cannot do SELECT u.* FROM User u"
  • "its fundamently broken imho, what if you change the property oder in mapping fields? that effects the result here and breaks code. its too much coupling imho between things that are not related"

@eltharin eltharin mentioned this pull request Jun 21, 2025
@eltharin eltharin mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants