Remove calls to getMockForAbstractClass()
#12003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c7607d to
d2cbab2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6a20f49 to
a308fec
Compare
a308fec to
c2cdb52
Compare
SenseException
approved these changes
Sep 16, 2025
greg0ire
reviewed
Sep 16, 2025
| $sqlExecMock->expects(self::once()) | ||
| ->method('execute') | ||
| ->willReturn(10); | ||
| $sqlExecMock = new class extends AbstractSqlExecutor { |
There was a problem hiding this comment.
This is no longer a mock… should it be renamed to include stub or dummy?
There was a problem hiding this comment.
No strong opinion here… What do you prefer?
| $strategy = new DefaultQuoteStrategy(); | ||
| $platform = $this->getMockForAbstractClass(AbstractPlatform::class); | ||
| assert($platform instanceof AbstractPlatform); | ||
| $platform = $this->createMock(AbstractPlatform::class); |
There was a problem hiding this comment.
We seem to have a polyfill for createStub in DoctrineTestCase, let's use it, here and below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit has deprecated partial mocking, so we should avoud calling
getMockForAbstractClass()in our tests.