Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Explicit example of partial indexes#1232

Merged
Ocramius merged 1 commit into
doctrine:masterfrom
PowerKiKi:doc-partial-indexes
Jan 22, 2015
Merged

Explicit example of partial indexes#1232
Ocramius merged 1 commit into
doctrine:masterfrom
PowerKiKi:doc-partial-indexes

Conversation

@PowerKiKi
Copy link
Copy Markdown
Contributor

This provide an explicit example of partial indexes annotations. Specifically including all parentheses as returned by PostgreSql.

This is needed following doctrine/dbal#716

@doctrinebot
Copy link
Copy Markdown

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3465

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Copy Markdown
Member

@PowerKiKi can you split the examples about partial indexes btw? I think they are quite misleading if integrated with "the basics" :-\

@PowerKiKi PowerKiKi force-pushed the doc-partial-indexes branch from 35ba813 to 3caaf26 Compare January 22, 2015 07:38
@PowerKiKi
Copy link
Copy Markdown
Contributor Author

@Ocramius updated the PR as you suggested. Thanks for the feedback.

@deeky666
Copy link
Copy Markdown
Member

Maybe we should add a notice about possible issues using the schema tool to update a schema if the where string does not exactly match the one returned by the database? Not sure... /cc @Ocramius
Otherwise we might get tickets about the schema tool being broken even though it rather is a limitation.

@PowerKiKi
Copy link
Copy Markdown
Contributor Author

I'll wait for the confirmation from @Ocramius, but in that case I would like to avoid duplicating that notice, and centralize everything about partial indexes in a single place. However I don't know where that would best fit... do you have an idea ? could it be at the bottom of that page ? or another page ?

@Ocramius
Copy link
Copy Markdown
Member

Maybe we should add a notice about possible issues using the schema tool to update a schema if the where string does not exactly match the one returned by the database?

Don't think so

Ocramius added a commit that referenced this pull request Jan 22, 2015
Explicit example of partial indexes
@Ocramius Ocramius merged commit 39c36f6 into doctrine:master Jan 22, 2015
@Ocramius
Copy link
Copy Markdown
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants