DDC-3493 - fixed EntityGenerator parsing for php 5.5 "::class" syntax#1256
Closed
asprega wants to merge 1 commit into
Closed
DDC-3493 - fixed EntityGenerator parsing for php 5.5 "::class" syntax#1256asprega wants to merge 1 commit into
asprega wants to merge 1 commit into
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3502 We use Jira to track the state of pull requests and the versions they got |
Member
|
@asprega thanks! Please include commits from failing tests next time (don't copy-paste them). I fixed that while merging. |
Member
Contributor
Author
|
@Ocramius I'm sorry, I was unsure of how to do a pull request by mixing commits from 2 separate repos. I just realized that I could have pulled the other commit by adding that other repo as another remote. I'll try that next time. |
This was referenced Dec 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not check for
$i > 0because at least a php opening tag is needed for the src to be valid PHP, so the class token can never be at index 0 (it can be at index 1 at the very least, e.g.<?class Foo .... Please let me know if you think I should add that check anyway.See pull request #1250.