[DDC-2704] - merge inherited transient properties - merge properties into uninitialized proxies#1272
Merged
Ocramius merged 20 commits intoJan 25, 2015
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3524 We use Jira to track the state of pull requests and the versions they got |
Member
Author
There was a problem hiding this comment.
This may be replaced with a static utility if the classmetadata changes are not required
… are not handled when in an inheritance
…ties in the class metadata
…d class metadata instance will result in a failure
…nitialized class metadata instance will result in a failure
…class metadata may not hold reflection class after wakeup)
…n metadata API when fetching reflection properties for a class
…ll to reflection property getter API)
10c7978 to
28e0da4
Compare
Ocramius
added a commit
that referenced
this pull request
Jan 25, 2015
…d-transient-properties [DDC-2704] - merge inherited transient properties - merge properties into uninitialized proxies
|
@Ocramius it still seems to fail for properties which where "injected" by Traits |
|
making them protected fixes this, but its not something i like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://www.doctrine-project.org/jira/browse/DDC-2704 - DDC-2704