Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hotfix/#1169 extra lazy one to many should not delete referenced entities#1281

Merged
Ocramius merged 16 commits into
doctrine:masterfrom
Ocramius:hotfix/#1169-extra-lazy-one-to-many-should-not-delete-referenced-entities
Jan 25, 2015
Merged

Hotfix/#1169 extra lazy one to many should not delete referenced entities#1281
Ocramius merged 16 commits into
doctrine:masterfrom
Ocramius:hotfix/#1169-extra-lazy-one-to-many-should-not-delete-referenced-entities

Conversation

@Ocramius
Copy link
Copy Markdown
Member

@Ocramius Ocramius commented Jan 24, 2015

This is an alternate fix for #1169 (DDC-3343 http://www.doctrine-project.org/jira/browse/DDC-3343)

Andrea Sprega and others added 12 commits January 24, 2015 11:30
@Ocramius
[DDC-3343] Failing test case
db36974
@Ocramius
[DDC-3343] Failing test case (updated)
c2b3348
@Ocramius
doctrine#1169 DDC-3343 - one-to-many extra-lazy should not delete ass…
f184956 
…ociated values when they are removed, but just update the owning side
@Ocramius
doctrine#1169 DDC-3343 - minor refactoring: constant over string refe…
aed01ea 
…rence
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test mo…
15397bb 
…dels
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test mo…
43f301f 
…dels
@Ocramius
doctrine#1169 DDC-3343 - optimized imports
ed0331d
@Ocramius
doctrine#1169 DDC-3343 - importing used classe
ff986a9
@Ocramius
doctrine#1169 DDC-3343 - integrating tests into the existing test suite
a8796fa
@Ocramius
doctrine#1169 DDC-3343 - removing duplicate test
99c5650
@Ocramius
doctrine#1169 DDC-3343 - correcting query count assertions on extra-l…
6a2b7c2 
…azy specific tests (some DELETE operations became UPDATE operations)
@Ocramius
doctrine#1169 DDC-3343 - additional test cases: removing proxies from…
d443d4f 
… an extra-lazy collection still updates the owning side values
@Ocramius Ocramius self-assigned this Jan 24, 2015
@doctrinebot
Copy link
Copy Markdown

doctrinebot commented Jan 24, 2015

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3536

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius mentioned this pull request Jan 24, 2015
Closed
@stof
Copy link
Copy Markdown
Member

stof commented Jan 24, 2015

looks good to me

@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Jan 24, 2015

@stof I'll provide a 2.4 PR as well in a few.

Ocramius
Ocramius reviewed Jan 24, 2015
View reviewed changes
Comment thread tests/Doctrine/Tests/ORM/Functional/ValueConversionType/OneToManyExtraLazyTest.php Outdated
Copy link
Copy Markdown
Member Author

@Ocramius Ocramius Jan 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are actually on the wrong file.

@Ocramius Ocramius mentioned this pull request Jan 24, 2015
Merged
Ocramius
Ocramius reviewed Jan 25, 2015
View reviewed changes
Comment thread lib/Doctrine/ORM/Cache/Persister/Collection/AbstractCollectionPersister.php
Copy link
Copy Markdown
Member Author

@Ocramius Ocramius Jan 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that none of the EXTRA_LAZY stuff was actually updating the collection-related caches. This change fixes that

Ocramius added a commit that referenced this pull request Jan 25, 2015
@Ocramius
Merge pull request #1281 from Ocramius/hotfix/#1169-extra-lazy-one-to…
5bf1829 
…-many-should-not-delete-referenced-entities

Hotfix/#1169 extra lazy one to many should not delete referenced entities
@Ocramius Ocramius merged commit 5bf1829 into doctrine:master Jan 25, 2015
@Ocramius Ocramius deleted the hotfix/#1169-extra-lazy-one-to-many-should-not-delete-referenced-entities branch January 25, 2015 04:43
beberlei
beberlei reviewed Jan 25, 2015
View reviewed changes
Comment thread lib/Doctrine/ORM/Persisters/Collection/OneToManyPersister.php
Copy link
Copy Markdown
Member

@beberlei beberlei Jan 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was intended to be used only be used with orphanRemoval=true, not always like it is now.

@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Jan 26, 2015

To recap, I need to fix following:

  • when using orphan-removal, this triggers a DELETE operation on the inverse side
  • when not using orphan-removal, this becomes no-op.

@Ocramius Ocramius mentioned this pull request Jan 27, 2015
Merged
@Ocramius
Copy link
Copy Markdown
Member Author

Ocramius commented Jan 27, 2015

Provided required hotfixes via #1288

This was referenced Dec 6, 2015
Closed
Closed
Closed
@lcobucci lcobucci added this to the 2.5.1 milestone Dec 20, 2017
@lcp0578 lcp0578 mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

Bug

Projects

None yet

Milestone

2.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Ocramius @doctrinebot @stof @beberlei @lcobucci